Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RJD-1057: Unify spawn API #1543

Draft
wants to merge 2 commits into
base: RJD1057/change-order-of-members
Choose a base branch
from
Draft

RJD-1057: Unify spawn API #1543

wants to merge 2 commits into from
+60 −92

Conversation

f0reachARR
Copy link
Contributor

Description

Abstract

This is a partial pull request of #1334.
Unify multiple spawn API to one spawn API

Background

There are three spawn API for each entity types.
This PR will unify them into one spawn API.
Also, spawn will return Entity instead of boolean of spawn result.

References

#1334

Known Limitations

Returned Entity is not used now. I will introduce it by another PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@f0reachARR f0reachARR marked this pull request as ready for review March 6, 2025 04:35
@f0reachARR f0reachARR mentioned this pull request Mar 6, 2025
Draft
@f0reachARR f0reachARR marked this pull request as draft March 6, 2025 04:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
42.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f0reachARR